RFR: 8260528: Clean glass-gtk sizing and positioning code [v35]
Thiago Milczarek Sayao
tsayao at openjdk.org
Tue Dec 20 19:48:58 UTC 2022
On Mon, 19 Dec 2022 15:29:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> **About Ubuntu 16.04:**
>> - `RestoreSceneSizeTest` should be fixed;
>> - I kept `gtk_window_focus_on_map` `TRUE` on Compiz - so it will behave as before;
>> - I introduced a `WindowManager` enum in case different work arounds are needed for other window managers;
>> - About Live resizing: master branch does not live resize as well (at least on my VM);
>>
>> **About the black area**
>> - It does not happen on a Ubuntu 20.04 VM I installed, but I did some overall improvements on consistency while testing on 16.04. Maybe it's gone.
>
>> **About Ubuntu 16.04:**
>>
>> * `RestoreSceneSizeTest` should be fixed;
>
> Confirmed. This now passes for me.
>
>> * I kept `gtk_window_focus_on_map` `TRUE` on Compiz - so it will behave as before;
>> * I introduced a `WindowManager` enum in case different work arounds are needed for other window managers;
>
> OK, I'll test it towards the middle of this week (I don't have direct access to my 16.04 system at the moment).
>
>> * About Live resizing: master branch does not live resize as well (at least on my VM);
>
> OK. This is not worth worrying about in any case.
>
>> **About the black area**
>>
>> * It does not happen on a Ubuntu 20.04 VM I installed, but I did some overall improvements on consistency while testing on 16.04. Maybe it's gone.
>
> I still see the black band consistently on my Ubuntu 20.04 VM.
@kevinrushforth are you using the default window manager on Ubuntu 20.04? Is it updated? Just so I can reproduce the issue (of the black header).
-------------
PR: https://git.openjdk.org/jfx/pull/915
More information about the openjfx-dev
mailing list