RFR: 8297554: Remove Scene.KeyHandler [v3]
Kevin Rushforth
kcr at openjdk.org
Tue Dec 20 20:24:04 UTC 2022
On Tue, 6 Dec 2022 16:46:19 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:
>> The `Scene.KeyHandler` class doesn't seem to have a clear purpose, mixing focus handling with event propagation. Since #852, `KeyHandler.setFocusVisible` is also called from mouse and touch event handlers, which makes the purpose of the class even less pronounced.
>>
>> Moving the focus-related functionality next to the other focus functions in the `Scene` class makes it easier to work with the code in the future.
>>
>> With the focus-related functions gone, `KeyHandler` only contains a single, small method that is called from `Scene.processKeyEvent`. For simplicity, this code can be rolled into `Scene.processKeyEvent` and the now-empty `KeyHandler` class can be removed.
>
> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>
> - Merge branch 'master' into fixes/keyhandler-refactor
> - review changes
> - Removed KeyHandler
@mstr2 The fix looks fine to me. I presume you have done enough testing to ensure no regressions?
I left a comment on the question raised by Ambarish.
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx/pull/962
More information about the openjfx-dev
mailing list