RFR: 8298728: Cells in VirtualFlow jump after resizing [v2]

Andy Goryachev angorya at openjdk.org
Wed Dec 21 23:45:56 UTC 2022


On Tue, 20 Dec 2022 17:49:13 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> When recalculating sizes, we often don't want the current index and/or offset to change.
>> 
>> Allow to fix the index/offset when doing recalculations.
>> 
>> Fix JDK-8298728
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   move statements to new lines.
>   Add another failing test, and a fix: when the cell that is positioned at the "current index"
>   is resized, we also need to modify the offset (wich is calculated from the top of that cell
>   to the start of the viewport).

1. I see the same issue with page up/page down described earlier (see the video clip attached to the jira ticket https://bugs.openjdk.org/secure/attachment/102048/does%20not%20page%20back%20to%20the%20same%20spot.mov )

2. I am still not clear what exactly the problem is.  The jira ticket contains conditionals ("if we want..."), rather than a typical `steps to reproduce -> expected to see -> actual behavior` steps.

Could you comment on #1 and #2 please?

-------------

PR: https://git.openjdk.org/jfx/pull/974


More information about the openjfx-dev mailing list