Integrated: 8292922 - [Linux] No more drag events when new Stage is created in drag handler

Thiago Milczarek Sayao tsayao at openjdk.org
Fri Dec 23 17:43:57 UTC 2022


On Sun, 18 Dec 2022 20:28:17 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

> This PR  was previously discussed on #905.
> 
> The approach is to grab the keyboard focus so the window that originated the drag will keep it.
> 
> I did some cleanup on grabbing related functions as well.
> 
> `gdk_keyboard_focus()` is deprecated, so is `gdk_device*` functions in favor of `gdk_seat*`. But that's only available in later Gtk versions. I checked and newer Gtk will use `gdk_seat*` inside the deprecated `gdk_keyboard_focus()`.
> 
> Edit:
> 
> The current changes uses another approach that is to not ungrab pointer device when focus is received on another window. There's also some cleanup on grabbing related functions and grab moved from starting on mouse click to the actual drag.

This pull request has now been integrated.

Changeset: a35c3bf7
Author:    Thiago Milczarek Sayao <tsayao at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/a35c3bf78b86c57d6e80d592e99f16ab349b0d8c
Stats:     101 lines in 2 files changed: 10 ins; 88 del; 3 mod

8292922: [Linux] No more drag events when new Stage is created in drag handler

Reviewed-by: angorya, kcr

-------------

PR: https://git.openjdk.org/jfx/pull/977


More information about the openjfx-dev mailing list