RFR: JDK-8298528: Clean up raw type warnings in base in bindings and collections packages

Michael Strauß mstrauss at openjdk.org
Mon Dec 26 03:28:53 UTC 2022


On Sun, 11 Dec 2022 20:12:17 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

> Packages fixed:
> - com.sun.javafx.binding
> - com.sun.javafx.collections
> - javafx.beans
> - javafx.beans.binding
> - javafx.collections
> - javafx.collections.transformation

modules/javafx.base/src/main/java/javafx/beans/binding/ListExpression.java line 238:

> 236:     public Iterator<E> iterator() {
> 237:         final ObservableList<E> list = get();
> 238:         return (list == null)? ListExpression.<E>emptyList().iterator() : list.iterator();

You're using three slightly different ways of referring to the empty list:
* `ListExpression.<E>emptyList()`
* `emptyList()`
* `EMPTY_LIST`

What do you think about using the first option in all cases?

-------------

PR: https://git.openjdk.org/jfx/pull/972


More information about the openjfx-dev mailing list