RFR: 8278021: Fix warnings in macOS glass native code and treat warnings as errors

[Sebastian Stenzel]

On Wed, 1 Dec 2021 17:44:21 GMT, Martin Fox <duke at openjdk.java.net> wrote:

> Turning on warnings-as-errors for the macOS glass native code. Deprecated declarations are excluded and still appear as warnings.
> 
> In the code that tries to locate the application's dock icon there were three instances where `NO` was being passed into a method that required a pointer to a `BOOL`, not a `BOOL`. I suspect the intent was to check that the path pointed to an existing file but not a directory. Since JavaFX has gone this long without screening out directories correctly I decided not to fix that behavior except at the very end.
> 
> The only other changes of note are sending some NSNotification objects to delegate API's that require them even though we know they're ignored on the other side. It was the easiest way to get rid of the warning.

What about usages of deprecated [NSWindowStyleMasks](https://developer.apple.com/documentation/appkit/nswindowstylemask) in `GlassWindow.m`? Shouldn't they get fixed as well?

e.g. `NSTexturedBackgroundWindowMask` → `NSWindowStyleMaskTexturedBackground`

-------------

PR: https://git.openjdk.java.net/jfx/pull/687