RFR: 8255940: localStorage is null after window.close() [v2]

[Kevin Rushforth]

On Sat, 5 Feb 2022 12:54:43 GMT, Jay Bhaskar <duke at openjdk.java.net> wrote:

>> We must check  if localstorage setting is disabled, then return nullptr first.,as below
>>     if (!page->settings().localStorageEnabled())
>>         return nullptr;
>> 
>> and there after the section 
>>     if (page->isClosing() && m_localStorage)
>>             return m_localStorage.get();
>> would become as below
>>     if (m_localStorage)
>>             return m_localStorage.get();
>
> in recent code base (webkit upgrade)the localstorage is false ,
> @@ -1579,7 +1579,7 @@ NeedsSiteSpecificQuirks:
>      WebKit:
>        default: true
>      WebCore:
> -      default: false
> +      default: true
> 
> So , it needs to be enable also.

1. My point was that if you initially check for `m_localStorage` being non-null, without the check for `isClosing` (see my earlier comment), then you don't need to check it here.

2. Regarding the enabling of local storage in WebCore, are you seeing any problems as a result of not having it enabled?

-------------

PR: https://git.openjdk.java.net/jfx/pull/703