RFR: 8273336: Clicking a selected cell from a group of selected cells in a TableView clears the selected items list but remains selected [v2]

Jose Pereda jpereda at openjdk.java.net
Mon Feb 7 10:24:02 UTC 2022


On Fri, 4 Feb 2022 17:33:18 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Address feedback from reviewer
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java line 172:
> 
>> 170:                     .map(TablePositionBase::getRow)
>> 171:                     .filter(removeRowFilter)
>> 172:                     .distinct()
> 
> Maybe `distinct` should be applied before `filter`. This can cut down the number of times the predicate is invoked (which iterates over all selected cells, so it may be a performance issue for large selections).

Makes sense. Done

-------------

PR: https://git.openjdk.java.net/jfx/pull/709


More information about the openjfx-dev mailing list