[jfx18] Integrated: 8279345: Realign class docs of LightBase and subclasses
Nir Lisker
nlisker at openjdk.java.net
Mon Feb 7 15:00:21 UTC 2022
On Sun, 16 Jan 2022 22:54:22 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
> Now that the standard concrete light types were added, there is an opportunity to rearrange and rewrite some of the class docs. Here is a summary of the changes:
>
> * Moved the explanations of attenuation and direction up to `LightBase` since different light types share characteristics. `LightBase` now contains a summary of its subtypes and all the explanations of the properties/characteristics of the lights divided into sections: Color, Scope, Direction, Attenuation.
> * Each light type links to the relevant section in `LightBase` when it mentioned the properties it has.
> * Added examples of real-world applications for each light type.
> * Consolidated the writing style for all the subclasses.
This pull request has now been integrated.
Changeset: ed399825
Author: Nir Lisker <nlisker at openjdk.org>
URL: https://git.openjdk.java.net/jfx/commit/ed39982515e1f4399841ffd75849988ff651396d
Stats: 152 lines in 5 files changed: 96 ins; 26 del; 30 mod
8279345: Realign class docs of LightBase and subclasses
Reviewed-by: kcr, arapte
-------------
PR: https://git.openjdk.java.net/jfx/pull/717
More information about the openjfx-dev
mailing list