[jfx18] RFR: 8271085: TabPane: Redundant API docs [v2]
Nir Lisker
nlisker at openjdk.java.net
Wed Feb 9 13:13:17 UTC 2022
On Wed, 9 Feb 2022 09:39:46 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>> This is a Javadoc cleanup and correction fix for the TabPane as described in the JBS.
>>
>> Changes done for all the Properties of the TabPane -
>> - Moved the property description to be over the property field.
>> - Removed the unnecessary docs on property setter/getter and Property method.
>
> Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision:
>
> Address review comments
Looks good to me. I added 1 optional comment.
modules/javafx.controls/src/main/java/javafx/scene/control/TabPane.java line 738:
> 736:
> 737: /**
> 738: * <p>This specifies how the {@code TabPane} handles tab closing from an end-user's
Since you are fixing the description here, can you remove the "This" in the beginning?
-------------
PR: https://git.openjdk.java.net/jfx/pull/728
More information about the openjfx-dev
mailing list