RFR: 8280841: Update SQLite to 3.37.2 [v2]

Kevin Rushforth kcr at openjdk.java.net
Wed Feb 9 14:57:14 UTC 2022


On Wed, 9 Feb 2022 04:40:49 GMT, Hima Bindu Meda <duke at openjdk.java.net> wrote:

>> Updated SQLite to 3.37.2 released on 2022-01-06 from the current version 3.32.3.
>> 
>> Website : https://www.sqlite.org/index.html
>> Source code can be found from https://www.sqlite.org/download.html at  [sqlite-amalgamation-3370200.zip](https://www.sqlite.org/2022/sqlite-amalgamation-3370200.zip)
>> 
>> Verified the updated version with unit tests and sanity testing.
>> No issues are observed.
>
> Hima Bindu Meda has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Create UPDATING.txt to explain SQLite version update

Sanity testing looks good. I left one comment on `UPDATING.txt`.

modules/javafx.web/src/main/native/Source/ThirdParty/sqlite/UPDATING.txt line 29:

> 27:    7.1 > cd modules/javafx.web/src/main/native/Source/ThirdParty/sqlite
> 28:    7.2 Remove tabs from source files:
> 29:      > sudo apt install moreutils

This section seems overly specific in terms of instructions. I think something something like the following, taken from `icu/UPDATING.txt`, might be sufficient:

7. Expand tabs and remove trailing white spaces from source files.

-------------

PR: https://git.openjdk.java.net/jfx/pull/727


More information about the openjfx-dev mailing list