RFR: 8187309: TreeCell must not change tree's data

[Jeanette Winzenburg]

On Tue, 8 Feb 2022 12:49:59 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Issue was TreeView commit editing implementation violated the spec'ed mechanism:
>> 
>> - no default commit handler on TreeView
>> - TreeCell modifying the data directly
>> 
>> Fix is to move the saving of the edited value from cell into a default commit handler in tree and set that handler in the constructor.
>> 
>> Added tests that failed/passed before/after the fix (along with a sanity test for default commit that passed also before). Also fixed a test bug (incorrect registration of custom commit handler, see [JDK-8280951)](https://bugs.openjdk.java.net/browse/JDK-8280951) in TreeViewTest.test_rt_29650 to keep it passing.
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeCellTest.java line 957:
> 
>> 955: 
>> 956:     /**
>> 957:      * Test test setup.
> 
> Minor: I would rephrase that a bit. Something like:
> `Tests the cell editing setup`.

oops .. forgot to change this (and the other comment) before integration - sry

-------------

PR: https://git.openjdk.java.net/jfx/pull/724