RFR: 8280020: Underline and line-through not straight in WebView

Kevin Rushforth kcr at openjdk.java.net
Thu Feb 10 21:08:15 UTC 2022


On Thu, 10 Feb 2022 11:36:38 GMT, Jay Bhaskar <duke at openjdk.java.net> wrote:

> Issue: The end point of  line in drawLinesForText , add thickness to the endPoint.y(). In this case origin which is start point and the end point would not be same, and line would be drawn not straight.
> Solution: Do not add thickness to the y position of end point of line.
> Start Point(x,y) ----------End Point(x + width, 0)

The fix looks good. The test needs to be different, since it doesn't actually test this fix. A good test will fail before the fix and pass after the fix. Since you need to render something, it needs to be a system test, probably using snapshot. See [PageFillTest.java](https://github.com/openjdk/jfx/tree/master/tests/system/src/test/java/test/javafx/scene/web/PageFillTest.java) for a recent example.

-------------

PR: https://git.openjdk.java.net/jfx/pull/731


More information about the openjfx-dev mailing list