RFR: 8280020: Underline and line-through not straight in WebView [v3]

[Jay Bhaskar]

On Sat, 19 Feb 2022 15:03:38 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update test case for line straightness check
>
> tests/system/src/test/java/test/javafx/scene/web/StraightLineTest.java line 167:
> 
>> 165:             int line_start_y = start_y + height;
>> 166:             String line_color = "rgba(0,0,0,255)"; // color of line
>> 167:             for (int i = line_start_y; i < snapshot.getHeight(); i++) {
> 
> The snapshot height is irrelevant. You should use thickness minus 6 (3 pixels on each of the top and bottom):
> 
> 
>     i < line_start_y + thickness - 6;

I think it should be like        for (int i = line_start_y; i <= (width - line_start_y -6); i++) , as we need to iterate in x direction

-------------

PR: https://git.openjdk.java.net/jfx/pull/731