RFR: 8278759 : PointerEvent: buttons property set to 0 when mouse down [v2]

[Hima Bindu Meda]

On Fri, 25 Feb 2022 00:30:28 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.web/src/main/native/Source/WebCore/platform/PlatformMouseEvent.h line 76:
>> 
>>> 74:        PlatformMouseEvent(const IntPoint& position, const IntPoint& globalPosition, MouseButton button, PlatformEvent::Type type,
>>> 75:                            int clickCount, bool shiftKey, bool ctrlKey, bool altKey, bool metaKey, WallTime timestamp, double force,
>>> 76:                            SyntheticClickType syntheticClickType, PointerID pointerId = mousePointerID)
>> 
>> I recommend reverting this change, since this is in WebKit shared code and the only change you made is in formatting. It will help avoid future merge conflicts.
>
> GitHub is showing more context than it should have, so my comment might be confusing. I only meant to suggest that you revert the reformatting of the existing constructor. Everything inside the `#if` looks fine.

Reverted the change from already existing webkit shared code.

>> tests/system/src/test/java/test/robot/javafx/web/PointerEventTest.java line 137:
>> 
>>> 135:         for (int i = 0; i < DRAG_DISTANCE; i++) {
>>> 136:                 final int c = i;
>>> 137:                 Util.runAndWait(() -> {
>> 
>> Minor: I think you can move the `runAndWait` outside the list, although that will change the timing slightly.
>> 
>> Whether or not you do this, the indentation is a little off (the first several lines are indented too much and the closing paren for the `Util.runAndWait` isn't lined up).
>
>> move the runAndWait outside the list...
> 
> I meant "loop"

updated the indentation

-------------

PR: https://git.openjdk.java.net/jfx/pull/742