RFR: 8197991: Selecting many items in a TableView is very slow [v5]

Abhinay Agarwal duke at openjdk.java.net
Thu Jan 6 08:17:53 UTC 2022


> This work improves the performance of `MultipleSelectionModel`  over large data sets by caching some values and avoiding unnecessary calls to `SelectedIndicesList#size`. It further improves the performance by reducing the number of iterations required to find the index of an element in the BitSet.
> 
> The work is based on [an abandoned patch](https://github.com/openjdk/jfx/pull/127) submitted by @yososs
> 
> There are currently 2 manual tests for this fix.

Abhinay Agarwal has updated the pull request incrementally with two additional commits since the last revision:

 - Remove commented out method. Document constructors.
 - Add tests

-------------

Changes:
  - all: https://git.openjdk.java.net/jfx/pull/673/files
  - new: https://git.openjdk.java.net/jfx/pull/673/files/2d321087..741aa92f

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jfx&pr=673&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jfx&pr=673&range=03-04

  Stats: 98 lines in 2 files changed: 58 ins; 40 del; 0 mod
  Patch: https://git.openjdk.java.net/jfx/pull/673.diff
  Fetch: git fetch https://git.openjdk.java.net/jfx pull/673/head:pull/673

PR: https://git.openjdk.java.net/jfx/pull/673


More information about the openjfx-dev mailing list