RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException [v3]

[Florian Kirmaier]

On Mon, 10 Jan 2022 12:29:04 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests "*MultipleSelectionModelImplTest*"`
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK_8256397
>   Added a small test-factory, to test more cases

I've rebased the PR to the current master.
I've also added some more test-cases.
It would be great if we could finish the PR, because it's already a year old.

If I make the following call, I get the following changes:

selectionModel.selectIndices(0,2,3);
c.getAddedSubList() -> [0, 2, 3]
selectionModel.selectIndices(1,4,5);
c.getAddedSubList() -> [1, 2, 3]

This looks wrong to me, but I don't know the logic too well, can this be somehow correct?
On the other side, I would like to finish it, without looking for other bugs.

-------------

PR: https://git.openjdk.java.net/jfx/pull/353