RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v4]

John Hendrikx jhendrikx at openjdk.java.net
Mon Jan 10 21:09:17 UTC 2022


On Thu, 6 Jan 2022 16:25:33 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply changes suggested in review and updated copyright years to 2022
>
> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java line 145:
> 
>> 143:     /**
>> 144:      * Creates an {@code ObservableValue} that holds the result of applying a
>> 145:      * mapping on the value held by this {@code ObservableValue}. The result is
> 
> After one of your suggestions, another phrasing for `on the value held by this {@code ObservableValue}` is `on this {@code ObservableValue}'s value`, which is a bit shorter. If you think it helps, you can make this change here and in other places. Fine to leave as it.

I did another grammar pass and have tried to use the same phrasing everywhere.

-------------

PR: https://git.openjdk.java.net/jfx/pull/675


More information about the openjfx-dev mailing list