RFR: 8277848 Binding and Unbinding to List leads to memory leak [v3]
Florian Kirmaier
fkirmaier at openjdk.java.net
Tue Jan 11 19:04:58 UTC 2022
On Wed, 5 Jan 2022 18:14:44 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:
>> Making the initial listener of the ListProperty weak fixes the problem.
>> The same is fixed for Set and Map.
>> Due to a smart implementation, this is done without any performance drawback.
>> (The trick is to have an object, which is both the WeakReference and the Changelistener)
>> By implying the same trick to the InvalidationListener, this should even improve the performance of the collection properties.
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8277848
> Further optimization based code review.
> This Bugfix should now event improve the performance
I've added the 3 requested whitespaces!
It sill would be great if CI could catch these minor problems.
-------------
PR: https://git.openjdk.java.net/jfx/pull/689
More information about the openjfx-dev
mailing list