RFR: 8242544: CMD+ENTER key event crashes the application when invoked on dialog [v2]
Martin Fox
duke at openjdk.java.net
Wed Jan 12 18:39:40 UTC 2022
On Wed, 12 Jan 2022 18:24:36 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Releasing dummy NSView
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassWindow.m line 849:
>
>> 847: NSView* dummy = [[NSView alloc] initWithFrame: NSMakeRect(0, 0, 10, 10)];
>> 848: [window->nsWindow performSelectorOnMainThread:@selector(setContentView:) withObject:dummy waitUntilDone:YES];
>> 849: [dummy release];
>
> This looks fine, given that we wait until the previous call to `performSelectorOnMainThread` is done.
For what it's worth I did complete a full run of robot-based system tests.
-------------
PR: https://git.openjdk.java.net/jfx/pull/714
More information about the openjfx-dev
mailing list