RFR: 8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed

Marius Hanl mhanl at openjdk.java.net
Fri Jan 14 20:12:33 UTC 2022


On Tue, 30 Nov 2021 12:32:37 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> The misbehaviour was that an edit handler received both a commit and cancel event when cell commitEdit is called. That happened whenever a collaborator reset the controls editing state (either directly or indirectly) while processing the editCommit event. The reason was that the cell had not yet updated its own editing state when receiving the change of editing from the control.
> 
> Fix is to update cell's editing state before firing the event, that is change the sequence or method calls from fire/super.commit to super.commit/fire.
> 
> Added tests that fail/pass before/after the fix.

Looks good to me.
I also did some manual tests and everything looks fine here too.

-------------

Marked as reviewed by mhanl (Author).

PR: https://git.openjdk.java.net/jfx/pull/684


More information about the openjfx-dev mailing list