Integrated: 8244234: MenuButton: NPE on removing from scene with open popup
eduardsdv
duke at openjdk.java.net
Tue Jan 18 14:54:33 UTC 2022
On Tue, 11 Jan 2022 14:42:19 GMT, eduardsdv <duke at openjdk.java.net> wrote:
> The NPE occurs when the skinnable is removed from the scene while the popup is showing.
> The MenuButtonSkinBase, when popup becomes hidden, tries to remove Mnemonics from the scene and runs into NPE.
> To avoid NPE a null-check is added to the 'showing' listener.
>
> Since the mnemonics cannot be removed from the scene in standard way, when popup becomes hidden.
> They are now also removed from the scene, when the skinnable is removed from it.
This pull request has now been integrated.
Changeset: 6e215263
Author: Eduard Sedov <eduard.sedov at zeiss.com>
Committer: Ajit Ghaisas <aghaisas at openjdk.org>
URL: https://git.openjdk.java.net/jfx/commit/6e215263e6fe94099528d386ccda65b22bce3138
Stats: 131 lines in 2 files changed: 126 ins; 1 del; 4 mod
8244234: MenuButton: NPE on removing from scene with open popup
Reviewed-by: aghaisas
-------------
PR: https://git.openjdk.java.net/jfx/pull/713
More information about the openjfx-dev
mailing list