Integrated: 8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Jan 20 11:51:58 UTC 2022


On Tue, 30 Nov 2021 12:32:37 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

> The misbehaviour was that an edit handler received both a commit and cancel event when cell commitEdit is called. That happened whenever a collaborator reset the controls editing state (either directly or indirectly) while processing the editCommit event. The reason was that the cell had not yet updated its own editing state when receiving the change of editing from the control.
> 
> Fix is to update cell's editing state before firing the event, that is change the sequence or method calls from fire/super.commit to super.commit/fire.
> 
> Added tests that fail/pass before/after the fix.

This pull request has now been integrated.

Changeset: 4c79c54c
Author:    Jeanette Winzenburg <fastegal at openjdk.org>
URL:       https://git.openjdk.java.net/jfx/commit/4c79c54c490031a9491790702c6bfb611d88f3b9
Stats:     158 lines in 8 files changed: 117 ins; 29 del; 12 mod

8187307: ListView, TableView, TreeView: receives editCancel event when edit is committed

Reviewed-by: mhanl, aghaisas

-------------

PR: https://git.openjdk.java.net/jfx/pull/684


More information about the openjfx-dev mailing list