RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v3]
Kevin Rushforth
kcr at openjdk.java.net
Tue Jan 25 15:25:34 UTC 2022
On Tue, 25 Jan 2022 14:34:09 GMT, meghanEmbrace <duke at openjdk.java.net> wrote:
>> With a touch-enabled device, the scrollbar disappears a short while after it's used. During the layout, updateHbar() checks the hbar visibility and resets the clip, causing the user to be scrolled fully to the left when trying to access columns on the right. Using hbar.isVisible() is not feasible as there are times when the scrollbar is necessary but not visible (such as on touch-enabled devices where the scrollbar disappears when not in use, or when hidden by CSS). Hence, it is more reliable to use the variable that determines whether the hbar is necessary.
>
> meghanEmbrace has updated the pull request incrementally with one additional commit since the last revision:
>
> Replaced the null test with an assert.
The updated test looks good.
I verified that the new test fails without the fix and passes with the fix. This is a simple enough fix that it doesn't need a second reviewer. I can sponsor it once you integrate it.
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.java.net/jfx/pull/688
More information about the openjfx-dev
mailing list