RFR: 8277853: With Touch enabled devices scrollbar disappears and the table is scrolled to the beginning [v3]

[Marius Hanl]

On Tue, 25 Jan 2022 14:34:09 GMT, meghanEmbrace <duke at openjdk.java.net> wrote:

>> With a touch-enabled device, the scrollbar disappears a short while after it's used. During the layout, updateHbar() checks the hbar visibility and resets the clip, causing the user to be scrolled fully to the left when trying to access columns on the right. Using hbar.isVisible() is not feasible as there are times when the scrollbar is necessary but not visible (such as on touch-enabled devices where the scrollbar disappears when not in use, or when hidden by CSS). Hence, it is more reliable to use the variable that determines whether the hbar is necessary.
>
> meghanEmbrace has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Replaced the null test with an assert.

modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java line 801:

> 799:      * Tests for specific bugs                                           *
> 800:      ********************************************************************/
> 801:     @Test public void test_jdk_8277853() {

Not sure if there is some preference around here but I always like if the test method is not just named after the ticket but instead what it actually tests, e.g. something like `testInvisibleScrollbarDoesNotScrollTableToBeginning`. Optionally the ticket number can be referenced in the javadoc then. But that's just me (just a side note here).

-------------

PR: https://git.openjdk.java.net/jfx/pull/688