RFR: 8277122: SplitPane divider drag can hang the layout [v2]

Jeanette Winzenburg fastegal at openjdk.java.net
Thu Jan 27 10:21:42 UTC 2022


On Wed, 26 Jan 2022 20:14:37 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> Hm, is this really needed? 

yes, IMO, we want the exact same cleanup for passing/failing tests. So either dispose is required always (then need to make sure it's called on failure) or not required always (then all its calls would be noise).

> Not sure, are there any side effects by the `StageLoader` like this when a test failed?  Just asking since the `StageLoader` is used a lot like this. 

don't now (and doesn't matter, what matters is the guaranteed cleanup) - and aware of those slightly fishy patterns, we all learn :) Faintly remember having discussed the point in a PR (can't find it right now, though), and just as faintly remember the outcome was to guarantee the cleanup in new tests.

-------------

PR: https://git.openjdk.java.net/jfx/pull/669


More information about the openjfx-dev mailing list