[jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses

[Michael Strauß]

On Thu, 27 Jan 2022 15:07:26 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Ambient light is a light that comes from all directions, scattered from different surfaces and it does not cast shadow. So I think the example of strong light and moon light should be avoided. Moon light is more like the Sun light, a directional light.
>
> What examples would you use?
> 
> If a light in a room is strong it will barely cast shadows since its reflections from all directions eliminate them.
> 
> Maybe I should mention that Ambient light can be used with a dark color to provide a base weak lighting of the environment, and on top of it use other lights.

I think the description should focus on the meaning of the respective term in the lighting equation, and not on a non-technical analogy. In this case, the analogy is a bit misleading on several aspects, including the fact that ambient lighting is not dependent on an area being enclosed. Here's a suggestion:

Ambient lights add a constant term to the amount of light reflected by each point on
the surface of an object, thereby increasing the brightness of the object uniformly and
independently of the orientation of its surfaces. It is often used to represent the base
amount of illumination in a scene.

-------------

PR: https://git.openjdk.java.net/jfx/pull/717