RFR: 8251481: TableCell accessing row: NPE on auto-sizing [v3]

Jeanette Winzenburg fastegal at openjdk.java.net
Sat Jan 29 14:01:16 UTC 2022


On Thu, 27 Jan 2022 20:38:56 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This PR will fix a simple NPE which may happens when using the `TableRow` inside a `TableCell` during the initial auto sizing.
>> In the auto sizing code, no `TableRow` is set, therefore `getTableRow()` will return null and it is not possible to e.g. access the row item.
>> 
>> This is fixed by adding the `TableRow` in the `resizeColumnToFitContent` method, similar as it is already done for the `TreeTableView` (`TreeTableRow`).
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8251481: Using global stageLoader now

looks good (there's one minor thingy in completely aligning the test for TreeTable)

modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableCellTest.java line 690:

> 688:      */
> 689:     @Test
> 690:     public void testRowIsNotNullWhenAutoSizing() {

same as autosizing test for TableCell: would like the issue id :)

-------------

Marked as reviewed by fastegal (Reviewer).

PR: https://git.openjdk.java.net/jfx/pull/716


More information about the openjfx-dev mailing list