RFR: 8289255: update Eclipse .classpath and other configuration files

Nir Lisker nlisker at openjdk.org
Sat Jul 2 00:48:50 UTC 2022 

On Mon, 27 Jun 2022 23:19:36 GMT, Andy Goryachev <duke at openjdk.org> wrote:

> summary of changes:
> - fixed .classpath files
> - set UTF-8 encoding in the eclipse project config files

I found my branch that was dealing with the Eclipse files update: https://github.com/openjdk/jfx/compare/master...nlisker:jfx:8221708_Update_Eclipse_project_files

It contains changes to the apps project too. I compared your changes with mine, although mine are outdated in some places.

* You can remove the eclipse project and classpath files from `jfx/buildSrc`. It's a groovy project that is not very relevant. it can be manually imported if someone needs it.
* I'm still getting errors in tests/system:

Description	Resource	Path	Location	Type
AfterAll cannot be resolved to a type	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 78	Java Problem
Assertions cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 68	Java Problem
Assertions cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 159	Java Problem
Assertions cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 162	Java Problem
Assumptions cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 64	Java Problem
BeforeAll cannot be resolved to a type	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 72	Java Problem
ClipboardTransferable cannot be resolved to a type	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 132	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 51	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 57	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 57	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 75	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 76	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 91	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 92	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 102	Java Problem
MacPasteboardShim cannot be resolved to a type	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 103	Java Problem
SunClipboard cannot be resolved to a type	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 146	Java Problem
Test cannot be resolved to a type	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 62	Java Problem
The import com.sun.glass.ui.mac cannot be resolved	MacPasteboardTest.java	/tests/system/src/test/java/test/com/sun/glass/ui/mac	line 30	Java Problem
The import org.junit.jupiter cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 33	Java Problem
The import org.junit.jupiter cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 34	Java Problem
The import org.junit.jupiter cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 35	Java Problem
The import org.junit.jupiter cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 36	Java Problem
The import org.junit.jupiter cannot be resolved	DoubleShortcutProcessingTest.java	/tests/system/src/test/java/test/robot/javafx/scene	line 37	Java Problem
The import sun.awt.datatransfer cannot be resolved	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 44	Java Problem
The import sun.awt.datatransfer cannot be resolved	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 45	Java Problem
The method clearNativeContext() of type ClipboardTest.CustomClipboard must override or implement a supertype method	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 192	Java Problem
The method getClipboardData(long) of type ClipboardTest.CustomClipboard must override or implement a supertype method	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 207	Java Problem
The method getClipboardFormats() of type ClipboardTest.CustomClipboard must override or implement a supertype method	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 202	Java Problem
The method getID() of type ClipboardTest.CustomClipboard must override or implement a supertype method	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 187	Java Problem
The method registerClipboardViewerChecked() of type ClipboardTest.CustomClipboard must override or implement a supertype method	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 216	Java Problem
The method setContentsNative(Transferable) of type ClipboardTest.CustomClipboard must override or implement a supertype method	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 197	Java Problem
The method unregisterClipboardViewerChecked() of type ClipboardTest.CustomClipboard must override or implement a supertype method	ClipboardTest.java	/tests/system/src/test/java/test/javafx/scene/input	line 221	Java Problem
The type com.sun.webkit.WebPage is not accessible	PageFillTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 28	Java Problem
The type com.sun.webkit.WebPage is not accessible	StraightLineTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 28	Java Problem
The type com.sun.webkit.WebPage is not accessible	WebPageTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 41	Java Problem
The type com.sun.webkit.WebPageShim is not accessible	PageFillTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 29	Java Problem
The type com.sun.webkit.WebPageShim is not accessible	StraightLineTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 29	Java Problem
The type com.sun.webkit.WebPageShim is not accessible	WebPageTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 42	Java Problem
WebPage cannot be resolved to a type	PageFillTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 184	Java Problem
WebPage cannot be resolved to a type	PageFillTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 237	Java Problem
WebPage cannot be resolved to a type	WebPageTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 138	Java Problem
WebPageShim cannot be resolved	PageFillTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 186	Java Problem
WebPageShim cannot be resolved	PageFillTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 239	Java Problem
WebPageShim cannot be resolved	WebPageTest.java	/tests/system/src/test/java/test/javafx/scene/web	line 140	Java Problem

Do you not get these?

modules/javafx.graphics/.classpath line 5:

> 3: 	<classpathentry kind="src" path="src/main/java"/>
> 4: 	<classpathentry kind="src" path="build/gensrc/jsl-prism"/>
> 5: 	<classpathentry kind="src" path="build/gensrc/jsl-decora"/>

I think that you can remove these source folders too.

Did you get errors with `build/hlsl/Decora` and `build/hlsl/Prism`? These are generated for Windows, so possibly on Linux/Mac you would get errors, but marking them with "ignore_optional_problems" should resolve these.

In general, we should be able to remove OS-specific folders.

modules/javafx.swing/.classpath line 9:

> 7: 		</attributes>
> 8: 	</classpathentry>
> 9: 	<classpathentry kind="src" output="testbin" path="src/test/java">

This folder doesn't exist, it should be giving you an error, does it not?

-------------

Changes requested by nlisker (Reviewer).

PR: https://git.openjdk.org/jfx/pull/804

More information about the openjfx-dev mailing list