RFR: 8289751: Multiple unit test failures after JDK-8251483
Kevin Rushforth
kcr at openjdk.org
Tue Jul 5 23:23:55 UTC 2022
On Tue, 5 Jul 2022 23:09:37 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
> As also discussed in the ticket, we need to disable/ignore this two tests for now.
>
> With the fix for [JDK-8251483](https://bugs.openjdk.org/browse/JDK-8251483) the table row item is never null in a non empty table cell.
> In the meantime with [JDK-8251480](https://bugs.openjdk.org/browse/JDK-8251480) and [JDK-8285197](https://bugs.openjdk.org/browse/JDK-8285197) we changed the table column header autosizing to be more complete by adding the table row to the setup.
> Unfortunately we don't set the table view for the table row, therefore it can not know the underlying item (he knows the index but not where he can get the corresponding data for that index) -> table row item can be null in a non empty table cell (again).
>
> This will be fixed in https://github.com/openjdk/jfx/pull/805 (and the tests can be reenabled)
Looks good. I confirm that all tests pass after this. As discussed in the JBS issue, we might want to file a follow-on issue to investigate the cascading failures caused when these two tests fail.
Thank you for fixing this quickly.
-------------
Marked as reviewed by kcr (Lead).
PR: https://git.openjdk.org/jfx/pull/811
More information about the openjfx-dev
mailing list