RFR: [WIP] 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v7]

Kevin Rushforth kcr at openjdk.org
Wed Jul 6 11:44:55 UTC 2022


On Mon, 30 May 2022 08:10:36 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> When the size of a ListCell is changed and a scrollTo method is invoked without having a layout calculation in between, the old (wrong) size is used to calculcate the total estimate. This happens e.g. when the size is changed in the `updateItem` method.
>> This PR will immediately resize the cell and sets the new value in the cache containing the cellsizes.
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Precalculate size of cells that are likely going to be used in rendering.
>   This avoid resizing cells after their position has been laid out, leading
>   to misalignments.
>   Relaxed some tests that check on the number of invocations on updateItem.
>   We heavily use the accumcell for calculating sizes, and that cell is released
>   every time, leading to a call to updateItem as well (but this call should
>   not do any CPU intensive work)

I guess this should be closed in favor of #808 ?

-------------

PR: https://git.openjdk.org/jfx/pull/712


More information about the openjfx-dev mailing list