RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v9]

[Kevin Rushforth]

On Wed, 6 Jul 2022 21:32:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 23 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into feature/focusvisible
>>  - Updated since tag
>>  - Update copyright headers
>>  - Merge branch 'master' into feature/focusvisible
>>  - fixed undeterministic test failures
>>  - minor wording change
>>  - restart github actions
>>  - Merge branch 'master' of https://github.com/mstr2/jfx into feature/focusvisible
>>  - changes per discussion, added test
>>  - wording
>>  - ... and 13 more: https://git.openjdk.org/jfx/compare/b608ace8...0c7d6e72
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/ButtonBehavior.java line 181:
> 
>> 179:      */
>> 180:     protected void mousePressed(MouseEvent e) {
>> 181:         if (getNode().isFocusTraversable()) {
> 
> The old code used to skip the call to `requestFocus()` if the node was already `focused` (here and in a couple other cases), in order to correctly update the `focusVisible` state. This is probably fine; can you think of any possible side effects of this?

that should read:

The old code used to skip the call to requestFocus() if the node was already focused (here and in a couple other cases). _It now always calls it_ in order to correctly update the focusVisible state.

-------------

PR: https://git.openjdk.org/jfx/pull/475