RFR: 8268225: Support :focus-visible and :focus-within CSS pseudoclasses [v10]

Ajit Ghaisas aghaisas at openjdk.org
Fri Jul 8 11:37:48 UTC 2022


On Wed, 6 Jul 2022 23:36:26 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> This PR adds the `Node.focusVisible` and `Node.focusWithin` properties, as well as the corresponding `:focus-visible` and `:focus-within` CSS pseudo-classes.
>
> Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
> 
>   address review comments

Overall this has baked well.
I have a very minor comment for a missing javadoc tag.

modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/behavior/FocusTraversalInputMap.java line 90:

> 88:      * @param node The node to traverse on
> 89:      * @param dir The direction to traverse
> 90:      */

Missing `@param` for traversal method.

-------------

PR: https://git.openjdk.org/jfx/pull/475


More information about the openjfx-dev mailing list