RFR: 8289255: update Eclipse .classpath and other configuration files [v8]
Andy Goryachev
duke at openjdk.org
Fri Jul 8 18:47:52 UTC 2022
On Fri, 8 Jul 2022 16:56:39 GMT, Andy Goryachev <duke at openjdk.org> wrote:
>> summary of changes:
>> - fixed .classpath files
>> - set UTF-8 encoding in the eclipse project config files
>>
>> the list of eclipse projects that do compile in Eclipse as a result of this PR are:
>> - base
>> - controls
>> - fxml
>> - graphics
>> - jfx
>> - media
>> - swing
>> - swt
>> - systemTests (can be dropped in favor ot tests
>> - tests
>> - web
>>
>> Not supported (should be removed from workspace or simply closed):
>> - apps
>> - apps/*
>> - buildSrc
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision:
>
> - added javafx.controls/com.sun.javafx.scene.control dependency
> - Merge remote-tracking branch 'origin/master' into JDK-8289255
> - 8289255: removed 3DViewer test folders from .classpath
> - Merge remote-tracking branch 'origin/master' into JDK-8289255
> - Merge remote-tracking branch 'origin/master' into JDK-8289255
> - 8289255 remove javafx.graphics/build/gensrc as source folder
> - 8289255 remove javafx.swing/src/test/java as source folder
> - Merge remote-tracking branch 'origin/master' into JDK-8289255
> - Revert "8279297: removed unused Shape.setMode method"
>
> This reverts commit 6b3b7e51f168a02f68c3bc0324528164680cb6c9.
> - 8279297: removed unused Shape.setMode method
> - ... and 4 more: https://git.openjdk.org/jfx/compare/2629aae0...e8f9898e
Nir, I think I understand what the problem is.
For the purposes of this PR, buildSrc, apps(toys, samples), tests are not included. (The purpose of this PR is to be able to compile in Eclipse and get to 0 warnings for essential parts).
systemTests *is* included, as it contains system tests, and I am not sure how eclipse actually handles this kind of nested .projects's (tests/.project and tests/system/.project). I will update this PR such that tests/ can be included instead of systemTests/.
apps/ will require more work, and is also impacted by the cleanup effort you and Kevin discussed in the related tickets. I would certainly like to participate in this effort, under a separate ticket.
To summarize, the list of eclipse projects that do compile in Eclipse as a result of this PR are:
- base
- controls
- fxml
- graphics
- jfx
- media
- swing
- swt
- systemTests (can be dropped in favor ot tests
- tests
- web
Not supported (should be removed from workspace or simply closed):
- apps
- apps/*
- buildSrc
-------------
PR: https://git.openjdk.org/jfx/pull/804
More information about the openjfx-dev
mailing list