RFR: 8289394: Fix warnings: Unlikely argument type

Andy Goryachev duke at openjdk.org
Fri Jul 8 20:52:15 UTC 2022


Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE.

This warning should be reclassified as an error, as it catches bugs missed by javac.  In this case, the following places seem to contain bugs:
- apps/samples/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/TimelineController.java
- modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/GetEvent.java

The fixes include:
- using objects of the right type
- adding @SuppressWarnings("unlikely-arg-type") in places where intended (e.g. assertFalse)

There was an earlier discussion about using IDE-specific @SuppressWarnings in the code.  While I might disagree (I think it is ok to use IDE-specific @SuppressWarnings), the tests can be reworked to avoid @SuppressWarnings.  Please let me know.  Thanks!

-------------

Commit messages:
 - 8289394: fixed whitespace
 - 8289394: fixed unlikely argument type warning

Changes: https://git.openjdk.org/jfx/pull/823/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=823&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8289394
  Stats: 48 lines in 15 files changed: 18 ins; 12 del; 18 mod
  Patch: https://git.openjdk.org/jfx/pull/823.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/823/head:pull/823

PR: https://git.openjdk.org/jfx/pull/823


More information about the openjfx-dev mailing list