RFR: 8288137: The set of available printers is not updated without application restart [v2]

Kevin Rushforth kcr at openjdk.org
Fri Jul 8 21:39:59 UTC 2022


On Fri, 8 Jul 2022 20:30:32 GMT, Phil Race <prr at openjdk.org> wrote:

>> This fixes the issue that the default printer or set of available printers is fixed from the first call to it in the lifetime of the application.
>> Now subsequent calls will check to see if there are changes.
>> A manual test is provided for verifying this - it requires you to add/remove printers at the system level to verify anything related to this fix.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8288137

modules/javafx.graphics/src/main/java/com/sun/prism/j2d/PrismPrintPipeline.java line 133:

> 131:                     PrintServiceLookup.lookupPrintServices(null, null);
> 132:             if ((newServices.length != printerSet.size()) ||
> 133:                     (lastTime + 120000) > System.currentTimeMillis()) {

I missed this earlier. The test is backwards. It should be `<` not `>` .

-------------

PR: https://git.openjdk.org/jfx/pull/817


More information about the openjfx-dev mailing list