RFR: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals() [v2]

Andy Goryachev duke at openjdk.org
Fri Jul 8 21:53:51 UTC 2022


On Fri, 8 Jul 2022 21:41:29 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8289389: toExternalForm()
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 2329:
> 
>> 2327:             return 0;
>> 2328:         }
>> 2329:         return location.hashCode();
> 
> Shouldn't this be: `location.toExternalForm().hashCode()`?

good point.  will fix.

-------------

PR: https://git.openjdk.org/jfx/pull/821


More information about the openjfx-dev mailing list