RFR: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals() [v2]

Kevin Rushforth kcr at openjdk.org
Sat Jul 9 12:23:55 UTC 2022


On Sat, 9 Jul 2022 01:28:20 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/CalculatedValue.java line 101:
>> 
>>> 99:         }
>>> 100:         return h;
>>> 101:     }
>> 
>> Just an example, but wouldn't: `Objects.hash(relative, origin, value)` here work just as well?
>
> Honestly, I would just turn this class into a `record` and everything will be taken care of. I'm not sure it is within the scope of the fix.

Such a change is definitely out of scope. More importantly, we can't use `record` anywhere in JavaFX until we bump the minimum version of the JDK needed to run JavaFX. I plan to start a discussion on the openjfx-dev mailing list, since it has been something I've wanted to do for a while now.

-------------

PR: https://git.openjdk.org/jfx/pull/821


More information about the openjfx-dev mailing list