RFR: 8277848 Binding and Unbinding to List leads to memory leak [v5]
Florian Kirmaier
fkirmaier at openjdk.org
Mon Jul 11 08:00:41 UTC 2022
> Making the initial listener of the ListProperty weak fixes the problem.
> The same is fixed for Set and Map.
> Due to a smart implementation, this is done without any performance drawback.
> (The trick is to have an object, which is both the WeakReference and the Changelistener)
> By implying the same trick to the InvalidationListener, this should even improve the performance of the collection properties.
Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
JDK-8277848
Added 3 more tests to verify that a bug discussed in the PR does not appear.
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/689/files
- new: https://git.openjdk.org/jfx/pull/689/files/acd470e1..5294483b
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=689&range=04
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=689&range=03-04
Stats: 33 lines in 3 files changed: 33 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jfx/pull/689.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/689/head:pull/689
PR: https://git.openjdk.org/jfx/pull/689
More information about the openjfx-dev
mailing list