RFR: 8289384: Fix warnings: method does not override the inherited method since it is private to a different package

Andy Goryachev duke at openjdk.org
Mon Jul 11 20:54:51 UTC 2022


On Mon, 11 Jul 2022 20:42:22 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I think it's a safe change (and this method should probably be made private, as it is only called from the same class).
>
>> I think it's a safe change
> 
> Agreed.
> 
>> (and this method should probably be made private, as it is only called from the same class).
> 
> No, it's called from `CachingShapeRep`, which you (necessarily) modified as part of this PR.

right, sorry - that's why I did not make it private.

(note to self: double check before responding)

-------------

PR: https://git.openjdk.org/jfx/pull/824


More information about the openjfx-dev mailing list