RFR: 8277785: ListView scrollTo jumps to wrong location when CellHeight is changed [v4]
Johan Vos
jvos at openjdk.org
Wed Jul 13 13:30:15 UTC 2022
On Tue, 12 Jul 2022 13:45:13 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>>
>> reverse one more expected/actual set of args.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 1074:
>
>> 1072: lastHeight = -1;
>> 1073: releaseCell(accumCell);
>> 1074: // accumCell = null;
>
> Is this intentional or did you may forgot to add back this two lines of code?
This is intentional -- it was already moved to comments, and there is no need to destroy the accumCell (releasing it is what we need)
-------------
PR: https://git.openjdk.org/jfx/pull/808
More information about the openjfx-dev
mailing list