Integrated: 8284676: TreeTableView loses sort ordering when applied on empty table

Ambarish Rapte arapte at openjdk.org
Wed Jul 13 15:06:14 UTC 2022


On Tue, 12 Jul 2022 15:59:17 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> Issue: In a TreeTableView if root item has no children then TreeTableView does not retain if a sort order is set.
> 
> Cause: This is a regression of fix for [JDK-8256283](https://bugs.openjdk.org/browse/JDK-8256283), which returned false from `SortPolicy.call()` function if root item has no children. This function is called from `TreeTableView.sort()` line #1863. When the returned value is false then line #1885 gets executed, which removes the sort order that was added.
> 
> Fix: The fix for [JDK-8256283](https://bugs.openjdk.org/browse/JDK-8256283) is modified to return true instead. Added a test that fails without and passes with fix.

This pull request has now been integrated.

Changeset: 0132ac89
Author:    Ambarish Rapte <arapte at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/0132ac89033334ec9d9ec6149d116e8c352f89ec
Stats:     15 lines in 2 files changed: 14 ins; 0 del; 1 mod

8284676: TreeTableView loses sort ordering when applied on empty table

Reviewed-by: kcr, jpereda

-------------

PR: https://git.openjdk.org/jfx/pull/825


More information about the openjfx-dev mailing list