[jfx19] RFR: 8290331 Binding value left null when immediately revalidated in invalidation listener [v2]

[John Hendrikx]

On Fri, 15 Jul 2022 01:08:46 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change explanatory comment to block comment
>
> modules/javafx.base/src/main/java/javafx/beans/binding/ObjectBinding.java line 184:
> 
>> 182:             ExpressionHelper.fireValueChangedEvent(helper);
>> 183: 
>> 184:             if (!valid) {  // if still invalid after calling listeners...
> 
> On a personal note: I think implementation comments are best presented as a block, and not describing individual lines of code. That makes it a bit easier for future authors to work with the code. But that's just my two cents 😊

I like block comments as well, I'll change it.

-------------

PR: https://git.openjdk.org/jfx/pull/829