RFR: 8289394: Fix warnings: Unlikely argument type [v2]

[Kevin Rushforth]

On Mon, 18 Jul 2022 21:50:00 GMT, Andy Goryachev <duke at openjdk.org> wrote:

>> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE.
>> 
>> This warning should be reclassified as an error, as it catches bugs missed by javac.  In this case, the following places seem to contain bugs:
>> - apps/samples/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/TimelineController.java
>> - modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/GetEvent.java
>> 
>> The fixes include:
>> - using objects of the right type
>> - adding @SuppressWarnings("unlikely-arg-type") in places where intended (e.g. assertFalse)
>> 
>> There was an earlier discussion about using IDE-specific @SuppressWarnings in the code.  While I might disagree (I think it is ok to use IDE-specific @SuppressWarnings), the tests can be reworked to avoid @SuppressWarnings.  Please let me know.  Thanks!
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
> 
>  - 8289394: review comments
>  - Merge remote-tracking branch 'origin/master' into 8289394.unlikely
>  - 8289394: fixed whitespace
>  - 8289394: fixed unlikely argument type warning

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.org/jfx/pull/823