RFR: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals() [v3]

Andy Goryachev duke at openjdk.org
Tue Jul 19 15:48:12 UTC 2022


On Tue, 19 Jul 2022 03:50:47 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8289389: minimize the impact of collision
>
> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 2322:
> 
>> 2320:         }
>> 2321:         return false;
>> 2322:     }
> 
> Same as `ListViewTest`.

in the case of FXMLoader, hashCode() also follows the logic of equals().
However, we could mix something specific to FXMLoader to the hash, to avoid collision with origin URL.

-------------

PR: https://git.openjdk.org/jfx/pull/821


More information about the openjfx-dev mailing list