RFR: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals() [v4]

John Hendrikx jhendrikx at openjdk.org
Thu Jul 21 22:24:11 UTC 2022


On Tue, 19 Jul 2022 15:48:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - added missing hashCode() methods
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - 8289389: review comments
>  - Merge remote-tracking branch 'origin/master' into 8289389.hash
>  - 8289389: minimize the impact of collision
>  - 8289389: toExternalForm()
>  - 8289389: implemented missing hashCode()

Yes, it's beyond the scope of PR. I suppose people will have to be careful as with all classes that are mutable and have decided to override equals/hashCode -- no reason to stop now I suppose.

-------------

PR: https://git.openjdk.org/jfx/pull/821


More information about the openjfx-dev mailing list