RFR: 8235491: Tree/TableView: implementation of isSelected(int) violates contract [v3]

Andy Goryachev angorya at openjdk.org
Tue Jul 26 16:08:09 UTC 2022


> …ontract
> 
> 1. reword SelectionModel.isSelected(int) javadoc, removing incorrect statement "Is functionally equivalent to calling <code>getSelectedIndices().contains(index)</code>." 
> 2. reimplement TableView.TableViewSelectionModel.isSelected(int) method to return true when at least one cell in *any* column is selected on the given row (was: *all* columns)
> 3. change selectRowWhenInSingleCellSelectionMode() and selectRowWhenInSingleCellSelectionMode2() in TableViewSelectionModelImplTest to reflect new reality.
> 
> NOTE: proposed change alters semantics of isSelected(int) method (in the right direction, in my opinion).

Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:

  8235491: review comments

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/839/files
  - new: https://git.openjdk.org/jfx/pull/839/files/2b76eddb..fcdf223d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=839&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.org/jfx/pull/839.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/839/head:pull/839

PR: https://git.openjdk.org/jfx/pull/839


More information about the openjfx-dev mailing list