RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment

Kevin Rushforth kcr at openjdk.org
Tue Jul 26 22:22:17 UTC 2022


On Tue, 26 Jul 2022 21:14:58 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> - replaced with exact functional equivalent (in the presence of exceptions, for example)

Looks good. I left one optional comment.

modules/javafx.graphics/src/main/java/com/sun/javafx/css/StyleManager.java line 1274:

> 1272: 
> 1273:                     StylesheetContainer container = platformUserAgentStylesheetContainers.get(n);
> 1274:                     if((isSame = fname.equals(container.fname)) == true) {

Minor: since you are updating this line, maybe add a space after the `if`? (although since it is preexisting, it's ok to leave it as-is)

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/851


More information about the openjfx-dev mailing list