RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

[Andy Goryachev]

On Tue, 26 Jul 2022 22:43:36 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - 8289397: review comments
>>  - Revert "8289397: functional equivalent"
>>    
>>    This reverts commit 6ae0ef60b186c75993fe7faa099140b26593d308.
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line 875:
> 
>> 873:     public static boolean assertionEnabled() {
>> 874:         boolean assertsEnabled = false;
>> 875:         assert (assertsEnabled = true) == true;
> 
> Is it worth leaving the "Intentional side-effect" comment?

i think *now* the code is clear without the comment!
(and the comment does not explain *why* it is intentional or what is the intention)

-------------

PR: https://git.openjdk.org/jfx/pull/851