RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

[Andy Goryachev]

On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - replaced with exact functional equivalent (in the presence of exceptions, for example)
>
> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - 8289397: review comments
>  - Revert "8289397: functional equivalent"
>    
>    This reverts commit 6ae0ef60b186c75993fe7faa099140b26593d308.

It looks like people split between two camps:
- those who prefer to leave the code as is and disable the warning (or suppressing the warning)
- those who prefer added value of the warning in preventing a possible bug

I just want to reiterate that paying attention to eclipse warnings already uncovered some bugs that went undetected for many years, so personally I do see value in addressing these.

However, at this point it is unclear to me how to proceed.  I can either ask for a consensus or vote, or withdraw this PR.

-------------

PR: https://git.openjdk.org/jfx/pull/851